Skip to content

Canton config for deploy.prod.yaml#173

Merged
thibauld merged 2 commits intomainfrom
HardlyDifficult-patch-1
Jun 12, 2025
Merged

Canton config for deploy.prod.yaml#173
thibauld merged 2 commits intomainfrom
HardlyDifficult-patch-1

Conversation

@HardlyDifficult
Copy link
Copy Markdown
Collaborator

What?

Please describe what you're trying to accomplish in this PR.

Why?

What problem does this solve? Why is this important? What's the context?

Screenshots (optional)

@cursor
Copy link
Copy Markdown

cursor Bot commented Jun 12, 2025

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_ab9ab07b-1aa9-455b-aca8-634557094a09).

@thibauld thibauld merged commit 09ce39d into main Jun 12, 2025
2 checks passed
@thibauld thibauld deleted the HardlyDifficult-patch-1 branch June 12, 2025 23:18
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dev Workflow Exposes Production Secrets

The deploy.dev.yaml workflow now injects production (FAIRMINT_MAINNET_*, TRANSFER_AGENT_MAINNET_CLIENT_SECRET) and DEVNET secrets into the dev runner and container. This exposes live-environment credentials on the less-trusted development host, creating an unnecessary security risk and increasing the blast radius if compromised. The workflow will also fail if these new secrets are not defined in the "dev" GitHub environment.

.github/workflows/deploy.dev.yaml#L58-L65

RPC_URL: ${{ secrets.RPC_URL }}
FAIRMINT_MAINNET_USER_ID: ${{ secrets.FAIRMINT_MAINNET_USER_ID }}
FAIRMINT_MAINNET_PARTY_ID: ${{ secrets.FAIRMINT_MAINNET_PARTY_ID }}
TRANSFER_AGENT_MAINNET_CLIENT_SECRET: ${{ secrets.TRANSFER_AGENT_MAINNET_CLIENT_SECRET }}
FAIRMINT_DEVNET_USER_ID: ${{ secrets.FAIRMINT_DEVNET_USER_ID }}
FAIRMINT_DEVNET_PARTY_ID: ${{ secrets.FAIRMINT_DEVNET_PARTY_ID }}
TRANSFER_AGENT_DEVNET_CLIENT_SECRET: ${{ secrets.TRANSFER_AGENT_DEVNET_CLIENT_SECRET }}

Fix in Cursor


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants